-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print link to debugger UI #32
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After successfully registering a debuggee, print a link to go to the appropriate UI.
R: @davorbonaci |
@@ -424,6 +424,12 @@ public static DataflowPipelineRunner fromOptions(PipelineOptions options) { | |||
return super.apply(new AssignWindows<>(transform), input); | |||
} | |||
|
|||
private String debuggerMessage(String projectId, String uniqifier) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: uniquifier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
LGTM. |
davorbonaci
added a commit
to GoogleCloudPlatform/DataflowJavaSDK
that referenced
this pull request
Mar 25, 2016
echauchot
added a commit
to echauchot/beam
that referenced
this pull request
May 12, 2017
tweise
pushed a commit
to tweise/beam
that referenced
this pull request
Mar 26, 2018
Wire in output union tags by PTransform local output name
tvalentyn
pushed a commit
to tvalentyn/beam
that referenced
this pull request
May 15, 2018
robertwb
pushed a commit
to robertwb/incubator-beam
that referenced
this pull request
Apr 30, 2020
* Migrated Runners page * Migrated Contribute page * Refactored redirected links
robertwb
pushed a commit
to robertwb/incubator-beam
that referenced
this pull request
Apr 30, 2020
* Migrated Runners page * Migrated Contribute page * Refactored redirected links
hengfengli
referenced
this pull request
in hengfengli/beam
Mar 21, 2022
sjvanrossum
pushed a commit
to sjvanrossum/beam
that referenced
this pull request
May 22, 2023
refactor: add RUST_CODER_PREFIX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After successfully registering a debuggee, print a link to go to the
appropriate UI.